libosmo-sccp[master]: sccp: add addressbook functionality for sccp addresses

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jun 18 09:00:19 UTC 2017


Patch Set 2:

(5 comments)

https://gerrit.osmocom.org/#/c/2924/2/include/osmocom/sigtran/sccp_sap.h
File include/osmocom/sigtran/sccp_sap.h:

Line 252: struct osmo_sccp_addr_list *
i wouldn't call the structure sccp_addr_list but something like sccp_addr_entry.  Calling it 'list' implies that you're returning a list of (matching) addresses, when in reality you are looking up a single address


https://gerrit.osmocom.org/#/c/2924/2/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

Line 904: 	struct osmo_sccp_addr *addr;
is there a good reason to dynamically allocate osmo_sccp_addr here, and not simply have it a regular member variable?


Line 1099:       "sccp-address .NAME",
I think the '.' in front of NAME means that the name may contain spaces (i.e. any number of additional tokens will be matched, as opposed to one token).  I don't think this is desirable,so let's just have NAME witout the .


Line 1308:       "global-title-indicator <0-255>", "Set Global Title Indicator\n" "GTI\n")
Please check the SCCP specs for the actual permitted range. ITU-T Q.711 to Q.714 are the relevant specs. I think it's muhc less bits than 8. same for translation-type and numbering plan below.


Line 1354:       "digits .DIGITS", "Set Global Title Digits\n" "Number digits\n")
we cannot represent spaces in the digit list, so please remove the '.'


-- 
To view, visit https://gerrit.osmocom.org/2924
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I068ed7f7d113dab88424a9d47bab7fc703bb7942
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list