[PATCH] libosmocore[master]: gprs_ns_test.c: Remove unused byte arrays

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Jun 18 08:43:28 UTC 2017


Review at  https://gerrit.osmocom.org/2951

gprs_ns_test.c: Remove unused byte arrays

Commit 0d4e949e229a649ffd0503d8e930dba8be7dd34d changed the code to use
functions with local variables holding the bytes, but forgot to remove
the old global variables.

This test fixes compilation warnings.

Change-Id: I140de30038222b0419423d8c4f9da1946651a4e7
---
M tests/gb/gprs_ns_test.c
1 file changed, 0 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/2951/1

diff --git a/tests/gb/gprs_ns_test.c b/tests/gb/gprs_ns_test.c
index 4c6fd39..456d8e3 100644
--- a/tests/gb/gprs_ns_test.c
+++ b/tests/gb/gprs_ns_test.c
@@ -178,61 +178,12 @@
 	send_bssgp_reset(nsi, src_addr, bvci);
 }
 
-/* GPRS Network Service, PDU type: NS_RESET,
- * Cause: O&M intervention, NS VCI: 0x1122, NSEI 0x1122
- */
-static const unsigned char gprs_ns_reset[12] = {
-	0x02, 0x00, 0x81, 0x01, 0x01, 0x82, 0x11, 0x22,
-	0x04, 0x82, 0x11, 0x22
-};
-
-/* GPRS Network Service, PDU type: NS_RESET,
- * Cause: O&M intervention, NS VCI: 0x3344, NSEI 0x1122
- */
-static const unsigned char gprs_ns_reset_vci2[12] = {
-	0x02, 0x00, 0x81, 0x01, 0x01, 0x82, 0x33, 0x44,
-	0x04, 0x82, 0x11, 0x22
-};
-
-/* GPRS Network Service, PDU type: NS_RESET,
- * Cause: O&M intervention, NS VCI: 0x1122, NSEI 0x3344
- */
-static const unsigned char gprs_ns_reset_nsei2[12] = {
-	0x02, 0x00, 0x81, 0x01, 0x01, 0x82, 0x11, 0x22,
-	0x04, 0x82, 0x33, 0x44
-};
-
-/* GPRS Network Service, PDU type: NS_ALIVE */
-static const unsigned char gprs_ns_alive[1] = {
-	0x0a
-};
-
 /* GPRS Network Service, PDU type: NS_STATUS,
  * Cause: PDU not compatible with the protocol state
  * PDU: NS_ALIVE
  */
 static const unsigned char gprs_ns_status_invalid_alive[7] = {
 	0x08, 0x00, 0x81, 0x0a, 0x02, 0x81, 0x0a
-};
-
-/* GPRS Network Service, PDU type: NS_ALIVE_ACK */
-static const unsigned char gprs_ns_alive_ack[1] = {
-	0x0b
-};
-
-/* GPRS Network Service, PDU type: NS_UNBLOCK */
-static const unsigned char gprs_ns_unblock[1] = {
-	0x06
-};
-
-
-/* GPRS Network Service, PDU type: NS_STATUS,
- * Cause: PDU not compatible with the protocol state
- * PDU: NS_RESET_ACK, NS VCI: 0x1122, NSEI 0x1122
- */
-static const unsigned char gprs_ns_status_invalid_reset_ack[15] = {
-	0x08, 0x00, 0x81, 0x0a, 0x02, 0x89, 0x03, 0x01,
-	0x82, 0x11, 0x22, 0x04, 0x82, 0x11, 0x22
 };
 
 /* GPRS Network Service, PDU type: NS_UNITDATA, BVCI 0 */

-- 
To view, visit https://gerrit.osmocom.org/2951
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I140de30038222b0419423d8c4f9da1946651a4e7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list