This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/2813/4//COMMIT_MSG Commit Message: Line 9: The layer 1 interface (l1_if.c) for osmo-trx does not include osmo-bts-trx? https://gerrit.osmocom.org/#/c/2813/3/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: Line 71: void l1if_fill_meas_res(struct osmo_phsap_prim *l1sap, uint8_t chan_nr, struct gsm_lchan *lchan, > Why do you need chan_nr and *lchan in parameters at the same time? Why can' chan_nr isn't always necessarily just a clean array index; on RSL there are bit masks and magic going on. Not sure if that's the case here, but I see the caller doing l1sap_chan2ss(chan_nr) to obtain the array index from the chan_nr, so I assume rather keep this separate. Is that right, dexter? https://gerrit.osmocom.org/#/c/2813/4/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: Line 72: uint32_t fn, float ber, float rssi, float toa); have you explained all of these in the commit log? it's lchan, fn, and changint 'ta' to 'toa'? (just asking because I don't know the code well) -- To view, visit https://gerrit.osmocom.org/2813 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife3c791ff50e8a866a97b9783ac7ef3ef2402a70 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes