[PATCH] osmo-trx[master]: uhd: Fix Tx-RX timing offset setting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Tom Tsou gerrit-no-reply at lists.osmocom.org
Thu Jun 15 23:07:58 UTC 2017


Review at  https://gerrit.osmocom.org/2926

uhd: Fix Tx-RX timing offset setting

Integer timestamp offset was set to zero due to bad cast-operator
precedence.

Change-Id: Ib1f524cc86416699b3c143e5faddb33d61380767
---
M Transceiver52M/UHDDevice.cpp
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/26/2926/1

diff --git a/Transceiver52M/UHDDevice.cpp b/Transceiver52M/UHDDevice.cpp
index fe084f7..a2660dc 100644
--- a/Transceiver52M/UHDDevice.cpp
+++ b/Transceiver52M/UHDDevice.cpp
@@ -437,7 +437,7 @@
 	tx_rate = usrp_dev->get_tx_rate();
 	rx_rate = usrp_dev->get_rx_rate();
 
-	ts_offset = (TIMESTAMP) desc.offset * rx_rate;
+	ts_offset = static_cast<TIMESTAMP>(desc.offset * rx_rate);
 	LOG(INFO) << "Rates configured for " << desc.str;
 }
 
@@ -828,7 +828,6 @@
 		uhd::stream_cmd_t::STREAM_MODE_STOP_CONTINUOUS;
 
 	usrp_dev->issue_stream_cmd(stream_cmd);
-
 	async_event_thrd->cancel();
 	async_event_thrd->join();
 	delete async_event_thrd;

-- 
To view, visit https://gerrit.osmocom.org/2926
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1f524cc86416699b3c143e5faddb33d61380767
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>



More information about the gerrit-log mailing list