openbsc[master]: bsc_init: Forget which SIs are valid for the trx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jun 15 11:04:29 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/2819/3/openbsc/src/libbsc/bsc_init.c
File openbsc/src/libbsc/bsc_init.c:

Line 118: 		rc = rsl_bcch_info(bts, trx, i, GSM_BTS_SI(bts, i), si_len);
we resolve 'bts' from trx->bts above, there's no point in passing both into the function. Please just pass trx, as trx->bts can allways dereferenced there.


-- 
To view, visit https://gerrit.osmocom.org/2819
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e288252a2e7709c4dae16b96a0b1512278847f
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list