osmo-gsm-tester[master]: Use a subdir of run_dir for each test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jun 15 09:16:23 UTC 2017


Patch Set 1:

(1 comment)

I am not all convinced that we will end up using a process over all tests runs in it, but it may happen. I think we agree though that for now we want to run processes in per-test scope, which is good. If later we want to add per-suite scope processes then we may need to add another list in suite_run to those kind of processes, and it may make sense moving the current one to the Test class.

Regarding your proposed modifications, I agree in simplifying it, but instead of having a suite_run._new_run_dir(name) which creates suite-name/suite-test/name, I'd prefer to have a suite_run.get_run_dir() and suite_run.get_test_run_dir() (which internally calls suite_run,get_run_dir + appends test-name) and build whatever is needed from there as it is done now using util.dir(), as we may want to do more complex stuff later on as described in the first paragraph.

What do you think?

https://gerrit.osmocom.org/#/c/2915/1/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 94:             self._run_dir = util.Dir(self.suite_run.get_run_dir().new_dir(self._name))
> rather self.name()
I initially did that but then the line number gets added which doesn't make sense imho.


-- 
To view, visit https://gerrit.osmocom.org/2915
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06be2dd21710e14c1337d13b1fe6c2f68f037957
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list