osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 15 02:20:58 UTC 2017


Patch Set 11: Code-Review-1

(7 comments)

whoa, I just found some old comments of mine that I forgot to post. I was going to accept this patch now, but maybe take a look at my old comments first... sorry to keep you busy for so long

https://gerrit.osmocom.org/#/c/2465/10/scripts/osmo-build.sh
File scripts/osmo-build.sh:

Line 43: #		# Holds all required dependencies in the following form:
rather "Return in stdout"?


Line 55: #		#                  (e.g. PARALLEL_MAKE="-j1" to disable mutlithreading)
PARALLEL_MAKE is not an argument, it is an environment variable


Line 56: #		# - arg 1: dep_project = the git repository name, gets places in a git.osmocom.org URL.
what? above you say $1 is "one of these script/functions", now it is a repository name? ... i.e. need to clarify whose script you're talking about


Line 58: #		# - arg 3: configuration (optional: $cfg used in osmo-build-dep.sh)
"options to pass to ./configure, see $cfg in osmo-build-dep.sh"


Line 61: #		"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
how is this verification step part of 'generic_deps'? It should be part of something with "build" in its name.


Line 109: 	# ( '/' separates job name and matrix-axis)
"in $JOB_NAME"


Line 170: 
would be nicer to need only one way to get branch and rev ...or to be given the branch from the caller and only need to determine the git hash


-- 
To view, visit https://gerrit.osmocom.org/2465
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484
Gerrit-PatchSet: 11
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: blobb <dr.blobb at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: blobb <dr.blobb at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list