osmo-bts[master]: Move common steps into common jenkins helper

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 15 02:03:36 UTC 2017


Patch Set 7: Code-Review-1

(2 comments)

seems you forgot to 'git add' the common script?

https://gerrit.osmocom.org/#/c/2894/7/contrib/jenkins_bts_trx.sh
File contrib/jenkins_bts_trx.sh:

Line 3: # shellcheck source=contrib/jenkins_common_prefix.sh
shellcheck?


Line 4: . $(dirname "$0")/jenkins_common_prefix.sh
I'd call it 'jenkins_common.sh', because 'prefix' is usually an installation destination passed to ./configure scripts.


-- 
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48b1f75179b9008d65219dd5a47c1ab3b886408
Gerrit-PatchSet: 7
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list