This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review+1 (2 comments) two unimportant cosmetics that you could tweak ... otherwise I'd +2 if I had the powers https://gerrit.osmocom.org/#/c/2920/2/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: Line 791: return shape; return convolve(); and drop shape, like above? Line 944: return shape; same? -- To view, visit https://gerrit.osmocom.org/2920 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If53da1bf77b5944b6117765fa98ce12e1ccdeede Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Tom Tsou <tom at tsou.cc> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Tom Tsou <tom at tsou.cc> Gerrit-HasComments: Yes