This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(5 comments)
https://gerrit.osmocom.org/#/c/2914/1//COMMIT_MSG
Commit Message:
Line 10: this test starts using it so it fixes it too.
"this test"? commit log: good to stick to imperative form:
"Fix bug in put_all()" should do here?
Line 12: The process list is also cleaned after the processes are stopped,
"is also cleaned"? Again in the imperative form rather describe directly what this patch does. That is the shortest and clearest way.
https://gerrit.osmocom.org/#/c/2914/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 514: for my_item in item_list:
I don't really like the "my_"... I'd choose just "item"
Line 516: my_item.pop(USED_KEY)
let's do just
item.pop(USED_KEY, None)
and then no 'if' is needed.
https://gerrit.osmocom.org/#/c/2914/1/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 293: process.terminate()
hmm, does it make sense to do this instead?
while self._processes:
self._processes.pop().terminate()
--
To view, visit https://gerrit.osmocom.org/2914
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12866045145544076c6c18786e1a54f18fc293
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes