osmo-ci[master]: Add script for fetching BTS-specific L1 headers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jun 13 12:17:30 UTC 2017


Patch Set 2: Code-Review+1

(1 comment)

There is a benefit in avoiding code dup, but there is also a benefit in having a plain self-contained script and less code complexity. I would be fine with the minimal amount of copy-paste we have, but ok.

What users do you have in mind? osmo-bts.git or others as well?

https://gerrit.osmocom.org/#/c/2893/2/scripts/osmo-layer1-headers.sh
File scripts/osmo-layer1-headers.sh:

Line 28: 	exit 0
unless we already have such model that does not require headers, IMHO this should rather exit 1


-- 
To view, visit https://gerrit.osmocom.org/2893
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I840533d5bf9233822bc0534a25c252f1cab0a7b0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list