This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 10: Code-Review+2 (4 comments) some replies and comments that are probably outdated. Patch Set 10 looks good! https://gerrit.osmocom.org/#/c/2779/8//COMMIT_MSG Commit Message: Line 42: register by waiting/polling the method "modem.is_connected()". Tests > ACK. Can I also write there that I don't agree and that I presonally prefer but semantically it doesn't matter which we wait for first; waiting for the modem first makes our pcaps a lot shorter because we don't flood it with ctrl requests. How can your opinion differ! :) https://gerrit.osmocom.org/#/c/2779/8/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 408: result_handler = lambda obj, result, user_data: defer(register_func, result, user_data) > You wrote: "We have to get out of the glib main loop before we can start ra we have not the faintest idea of what magic glib may be doing. Maybe it's calling some C code calling back to python, maybe it has a thread running concurrently to launch callbacks (it doesn't, but are we sure?). We do want our own exceptions to be handled in the way we need: synchronously and with readable tracebacks. I remain certain that we do not want to do anything inside glib code at all, apart from noting that we want to do something later. Line 422: netreg = self.dbus.interface(I_NETREG) > schedule_scan_register should not be called for tests, at least for now, on Have you tested the DBus API? If calling netreg.Register directly without a Scan works, then we should skip the scan. https://gerrit.osmocom.org/#/c/2779/10/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 409: error_handler = lambda obj, e, user_data: defer(self.raise_exn, 'Scan() failed:', e) nice! -- To view, visit https://gerrit.osmocom.org/2779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c Gerrit-PatchSet: 10 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes