[PATCH] osmo-gsm-tester[master]: osmo-msc: configure HLR address

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 8 21:26:32 UTC 2017


Review at  https://gerrit.osmocom.org/2860

osmo-msc: configure HLR address

In db59bcf9fcdc5f05fdb9047b905ab497472440bc we added a configured GSUP server
address for the osmo-hlr, but the osmo-msc is still trying to connect to
127.0.0.1.

In the same way as for mgcpgw, add conf_for_msc() to OsmoHLR, and use that to
configure the HLR's address in osmo-msc.cfg.

Change-Id: I005aa160c679fc92b248abd762888959bd5b2c55
---
M src/osmo_gsm_tester/osmo_hlr.py
M src/osmo_gsm_tester/osmo_msc.py
M src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl
3 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/60/2860/1

diff --git a/src/osmo_gsm_tester/osmo_hlr.py b/src/osmo_gsm_tester/osmo_hlr.py
index 354eb1d..3492f06 100644
--- a/src/osmo_gsm_tester/osmo_hlr.py
+++ b/src/osmo_gsm_tester/osmo_hlr.py
@@ -126,4 +126,7 @@
             % (subscriber_id, modem.imsi(), modem.msisdn))
         return subscriber_id
 
+    def conf_for_msc(self):
+        return dict(hlr=dict(ip_address=self.ip_address))
+
 # vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/osmo_msc.py b/src/osmo_gsm_tester/osmo_msc.py
index ca0e246..2ef88df 100644
--- a/src/osmo_gsm_tester/osmo_msc.py
+++ b/src/osmo_gsm_tester/osmo_msc.py
@@ -72,6 +72,7 @@
         config.overlay(values, self.suite_run.config())
         config.overlay(values, dict(msc=dict(ip_address=self.ip_address)))
         config.overlay(values, self.mgcpgw.conf_for_msc())
+        config.overlay(values, self.hlr.conf_for_msc())
 
         self.dbg('MSC CONFIG:\n' + pprint.pformat(values))
 
diff --git a/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl
index c52d0dc..247365e 100644
--- a/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl
@@ -28,3 +28,5 @@
  esme test
   password test
   default-route
+hlr
+ remote-ip ${hlr.ip_address.addr}

-- 
To view, visit https://gerrit.osmocom.org/2860
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I005aa160c679fc92b248abd762888959bd5b2c55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list