osmo-gsm-tester[master]: ofono_client: Implement network registration during connect()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Jun 7 21:01:20 UTC 2017


Patch Set 8:

(6 comments)

https://gerrit.osmocom.org/#/c/2779/8//COMMIT_MSG
Commit Message:

Line 15: We get the MNC+MCC parameter from the MSC/NITB and we pass it to the
> MCC+MNC, country code is higher level than network code (same below)
ACK


Line 29: directly by pydbus. This way, we can continue polling while waiting for
> the most important point here IMHO is that we can scan and register several
ACK, will add at the end of the sentence: "and we can register several modems in parallel."


Line 42: 
> maybe mention why we wait for the modem first and then check with the MSC
ACK. Can I also write there that I don't agree and that I presonally prefer to put them in the inverse order? :P


https://gerrit.osmocom.org/#/c/2779/8/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:

Line 408:     def scan_error_cb(self, obj, e, user_data):
> defer
You wrote: "We have to get out of the glib main loop before we can start raising exceptions. We do the defer() stuff to avoid calling more things from inside the glib main loop, this is needed here as well."

We cannot raise exceptions inside the glib mainloop? what's the reason behind that? I don't remember it.

I'll use defer then, but not sure if it's really needed here tbh.


Line 411:     def scan_result_cb(self, obj, result, user_data):
> defer
same


Line 422:     def register(self, scanned_operators):
> is a test script allowed to call register() directly? Is it only called fro
schedule_scan_register should not be called for tests, at least for now, only connect() should be used. If that's used, then at some point we can move the poweroff+poweron from inside connect somewhere else.

for register_automatic, I'll iterate over scanned_operators and checking if any of them is marked with Status==current.

Regarding your question: "On a different note, if we have mcc_mnc == None, do we even need to scan in the first place?"
Well, my intuition says that to be able to select and connect automatically to any operator, you first need to find which operators are there so the modem can choose how to register right?


-- 
To view, visit https://gerrit.osmocom.org/2779
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c
Gerrit-PatchSet: 8
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list