This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 7: (6 comments) almost done here. https://gerrit.osmocom.org/#/c/2779/8//COMMIT_MSG Commit Message: Line 15 MCC+MNC, country code is higher level than network code (same below) Line 29 the most important point here IMHO is that we can scan and register several modems in parallel, without waiting for each of them sequentially. Line 42 maybe mention why we wait for the modem first and then check with the MSC https://gerrit.osmocom.org/#/c/2779/7/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 410: def scan_error_cb(self, obj, e, user_data): > AFAIK it's called by the glib mainloop, which means it's on the same thread We have to get out of the glib main loop before we can start raising exceptions. We do the defer() stuff to avoid calling more things from inside the glib main loop, this is needed here as well. Line 413: def scan_result_cb(self, obj, result, user_data): > same async question also here: we should not initiate DBus actions while still in the glib main loop. Line 418: if not self.is_connected(): > I could check for both by doing self.is_connected(self.mcc_mnc) but I still I still find it weird: in this function we get passed a list of scanned_operators, if we are attached to one of them it says 'Status' == 'current'. For the mcc_mnc == None case this just ignores those and asks for more properties. Can't we have a loop over the scanned_operators for both code paths, and if we find any 'current' one just succeed if mcc_mnc is None? On a different note, if we have mcc_mnc == None, do we even need to scan in the first place? (I don't want to drag this out and make your life difficult, but this feels like an irregularity in the code) -- To view, visit https://gerrit.osmocom.org/2779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c Gerrit-PatchSet: 7 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes