osmo-gsm-tester[master]: ofono_client: Implement network registration during connect()

[Pau Espin Pedrol]

Patch Set 6:

(5 comments)

https://gerrit.osmocom.org/#/c/2779/6/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:

Line 414:         if self.mcc is None or self.mnc is None:
> I assume that mcc_mnc is either set, i.e. a tuple of two number strings, or
ACK, will consider only either None or a complete tuple without None elements.


Line 427:                     self.log('Already registered with the network')
> I'd prefer: have one separate function to return true when we are already c
I'll have a look at the API what's the best way of checking that and come with a new version using that.


Line 454:         self.mcc, self.mnc = mcc_mnc
> IMHO store it as mcc_mnc everywhere. If you need to check separately, do th
ACK


https://gerrit.osmocom.org/#/c/2779/6/suites/debug/interactive.py
File suites/debug/interactive.py:

Line 30:          wait(m.is_connected)
> we wait until both are true, so the order doesn't matter much semantically.
As I said I still think it makes more sense from time-sequence point of view to check as it's done in here and having some extra packets in the pcap file is not a big issue for me, but OK, I'll swap them.


https://gerrit.osmocom.org/#/c/2779/6/suites/netreg/register_default.py
File suites/netreg/register_default.py:

Line 18: print(ms.properties())
> (rather use ms.info() I guess, properties() are bloated)
ACK


-- 
To view, visit https://gerrit.osmocom.org/2779
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c
Gerrit-PatchSet: 6
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes