[PATCH] osmo-bts[master]: measurement: Fix measurement reporting period tables

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Jun 2 15:54:44 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2795

to look at the new patch set (#2).

measurement: Fix measurement reporting period tables

The offsets, which are subtracted from the values specified in the
measurement period tables (tchh0_meas_rep_fn104[] and
tchh1_meas_rep_fn104[]) for half rate are off by one.

Change-Id: I4e0fdf081e0e28bed7d2b04f47ebc26bd2b94658
---
M src/common/measurement.c
1 file changed, 17 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/2795/2

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 22ab27c..e4d243f 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -36,28 +36,27 @@
 	[7] =	90 - 1,
 };
 
-/* Added (-2) offset in DATA-IND frame number to align with Meas period ends */
+/* Added (-1) offset in DATA-IND frame number to align with Meas period ends */
 static const uint8_t tchh0_meas_rep_fn104[] = {
-	[0] =	103 - 2,
-	[1] =	103 - 2,
-	[2] =	25 - 2,
-	[3] =	25 - 2,
-	[4] =	51 - 2,
-	[5] =	51 - 2,
-	[6] =	77 - 2,
-	[7] =	77 - 2,
+	[0] =	103 - 1,
+	[1] =	103 - 1,
+	[2] =	25 - 1,
+	[3] =	25 - 1,
+	[4] =	51 - 1,
+	[5] =	51 - 1,
+	[6] =	77 - 1,
+	[7] =	77 - 1,
 };
 
-/* Added (-1) offset in DATA-IND frame number to align with Meas period ends */
 static const uint8_t tchh1_meas_rep_fn104[] = {
-	[0] =	12 - 1,
-	[1] =	12 - 1,
-	[2] =	38 - 1,
-	[3] =	38 - 1,
-	[4] =	64 - 1,
-	[5] =	64 - 1,
-	[6] =	90 - 1,
-	[7] =	90 - 1,
+	[0] =	12,
+	[1] =	12,
+	[2] =	38,
+	[3] =	38,
+	[4] =	64,
+	[5] =	64,
+	[6] =	90,
+	[7] =	90,
 };
 
 /* Measurment reporting period for SDCCH8 and SDCCH4 chan

-- 
To view, visit https://gerrit.osmocom.org/2795
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e0fdf081e0e28bed7d2b04f47ebc26bd2b94658
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list