This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3370 to look at the new patch set (#3). VIRT-PHY: Print NOTICE log message from unimplemented stubs There are plenty of functions stubbed out in osmo-bts-virtual, let's print a NOTICE level log message to be able to correlate any kind of erroneous behavior with the fact that a given function has no actual implementation. Change-Id: Ib607d192f90af7fb2d5a8747de5527f39e3cfefa --- M src/osmo-bts-virtual/bts_model.c M src/osmo-bts-virtual/main.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/3370/3 diff --git a/src/osmo-bts-virtual/bts_model.c b/src/osmo-bts-virtual/bts_model.c index 5293cc3..c82f1aa 100644 --- a/src/osmo-bts-virtual/bts_model.c +++ b/src/osmo-bts-virtual/bts_model.c @@ -38,6 +38,7 @@ /* TODO: check if dummy method is sufficient, else implement */ int bts_model_lchan_deactivate(struct gsm_lchan *lchan) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return -1; } @@ -45,16 +46,19 @@ int osmo_amr_rtp_dec(const uint8_t *rtppayload, int payload_len, uint8_t *cmr, int8_t *cmi, enum osmo_amr_type *ft, enum osmo_amr_quality *bfi, int8_t *sti) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return -1; } int bts_model_trx_close(struct gsm_bts_trx *trx) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return 0; } int bts_model_adjst_ms_pwr(struct gsm_lchan *lchan) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return 0; } @@ -86,6 +90,7 @@ static uint8_t vbts_set_trx(struct gsm_bts_trx *trx) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return 0; } @@ -154,16 +159,19 @@ int bts_model_trx_deact_rf(struct gsm_bts_trx *trx) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return 0; } int bts_model_change_power(struct gsm_bts_trx *trx, int p_trxout_mdBm) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return 0; } int bts_model_ctrl_cmds_install(struct gsm_bts *bts) { + LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return 0; } diff --git a/src/osmo-bts-virtual/main.c b/src/osmo-bts-virtual/main.c index f1dc293..937046b 100644 --- a/src/osmo-bts-virtual/main.c +++ b/src/osmo-bts-virtual/main.c @@ -51,6 +51,7 @@ /* dummy, since no direct dsp support */ uint32_t trx_get_hlayer1(struct gsm_bts_trx *trx) { + LOGP(DSUM, LOGL_NOTICE, "Unimplemneted %s\n", __func__); return 0; } @@ -68,6 +69,7 @@ void bts_model_print_help() { + LOGP(DSUM, LOGL_NOTICE, "Unimplemented %s\n", __func__); } int bts_model_handle_options(int argc, char **argv) @@ -112,15 +114,18 @@ void bts_model_phy_instance_set_defaults(struct phy_instance *pinst) { + LOGP(DSUM, LOGL_NOTICE, "Unimplemented %s\n", __func__); } int bts_model_ts_disconnect(struct gsm_bts_trx_ts *ts) { + LOGP(DSUM, LOGL_NOTICE, "Unimplemented %s\n", __func__); return -ENOTSUP; } int bts_model_ts_connect(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config as_pchan) { + LOGP(DSUM, LOGL_NOTICE, "Unimplemented %s\n", __func__); return -ENOTSUP; } -- To view, visit https://gerrit.osmocom.org/3370 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib607d192f90af7fb2d5a8747de5527f39e3cfefa Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder