This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/3354 sccp: fix possible nullpointer deref check input parameters local_ip and remote_ip of the function osmo_sccp_simple_client_on_ss7_id() before using them with talloc_strdup() Change-Id: I1a5dd1ea3167513bf9e7ae153f83e1ae3136c905 --- M src/sccp_user.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/54/3354/1 diff --git a/src/sccp_user.c b/src/sccp_user.c index c9443a2..1805cff 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -331,8 +331,10 @@ goto out_rt; asp_created = true; - asp->cfg.local.host = talloc_strdup(asp, local_ip); - asp->cfg.remote.host = talloc_strdup(asp, remote_ip); + if (local_ip) + asp->cfg.local.host = talloc_strdup(asp, local_ip); + if (remote_ip) + asp->cfg.remote.host = talloc_strdup(asp, remote_ip); osmo_ss7_as_add_asp(as, asp->cfg.name); } -- To view, visit https://gerrit.osmocom.org/3354 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a5dd1ea3167513bf9e7ae153f83e1ae3136c905 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de>