This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(5 comments)
https://gerrit.osmocom.org/#/c/3129/3/src/osmo_gsm_tester/esme.py
File src/osmo_gsm_tester/esme.py:
Line 98: lambda pdu: self.dbg('message sent unhandled resp:', pdu.sequence) )
> clarify ... "message we are sending contains an unhandled response"? can't
This API from python-smpplib is quite misleading. Looking at the code, this handler is actually called when a message of type submit_sm_resp is received (a response from the server to our submit_sm request). I will change the message to: "Unhandled submit_sm_resp message"
Line 116: def message_received_handler(self, pdu, *args):
> might be good to indicate that this is not part of the intended testing API
Agree
Line 126: self.log('FIXME: wait_receipt disabled because receipts are not received, see OsmoNITB #2353')
> hmm, we don't have an expected-to-fail mechanism yet. this would qualify to
IMHO an expeted-to-fail mechanism can be marking the test as SKIP, but that should be done by the test, not by an internal API. Let's leave it like this for now as I don't want to spend time adding this kind of features now.
Line 166: def process_pdus_pending(self, pdu, **kwargs):
> public API or internal?
Internal, I'll prepend an underscore.
https://gerrit.osmocom.org/#/c/3129/3/suites/aoip_smpp/esme_ms_sms_storeforward.py
File suites/aoip_smpp/esme_ms_sms_storeforward.py:
Line 52: wait(esme.receipt_was_received, umref)
> ...like
another option:
try:
wait(...)
except ExpectedFailure:
suite.test_set_skip()
return
--
To view, visit https://gerrit.osmocom.org/3129
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c0c325fee14143deca8310312fc530cd9ce92e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes