This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/3265/2/src/osmo_ss7_vty.c File src/osmo_ss7_vty.c: Line 966: llist_for_each_entry(entry, &sccp_address_book_global, in the vty command to remove an address book entry, we call this function to remove a specific instance's address book entry. It feels a bit shaky that this function could techincally return a different instance's entry; that vty could OSMO_ASSERT(inst) to guard against that case -- but IMHO it's better to have a separate function to search globally: these are already two entirely distinct function bodies separated by an if(). -- To view, visit https://gerrit.osmocom.org/3265 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5acc1e5abc3b3081149a9f476038e4e53d23b763 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes