libosmo-sccp[master]: sccp: ensure addressbook entry names are unique

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jul 19 12:32:42 UTC 2017


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/3292/1/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

Line 1209: 	}
(Hmm, I would have expected to see an API function that adds an address which the vty calls, and to forbid duplicates in that function. But ok, if so far the only way to manage address book entries is the vty command, I can accept it. A separate address management API would have made sense, but no need to add it now, "unfortunately")


-- 
To view, visit https://gerrit.osmocom.org/3292
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63227cd87bc24f7d9ac995430b869f0393818335
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list