This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
allesklar2 gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(1 comment)
> Patch Set 2: Published edit on patch set 1.
https://gerrit.osmocom.org/#/c/2817/1/src/conv_enc_test.c
File src/conv_enc_test.c:
PS1, Line 53: void dp_sap_udata_ind(enum tp_sap_data_type type, const uint8_t *bits, unsigned int len, void *priv)
: {
: }
> Just a hint: you can use grep to find, where this
During the development I have oriented to TMO and the function tp_sap_udata_ind() is also empty. I suspect that these functions must exist in order to preserve the independence from the MAC Layer. Since the function is specified in lower_mac_layer and is defined as extern in tetra_burst.h, it must be listed as a dummy at this point.
Does this make sense for you?
--
To view, visit https://gerrit.osmocom.org/2817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa5521d7313595384e74dd790a56550755b93fe9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-tetra
Gerrit-Branch: laforge/sq5bpf-rebase-20161218
Gerrit-Owner: allesklar2 <jjuergens at seemoo.tu-darmstadt.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: allesklar2 <jjuergens at seemoo.tu-darmstadt.de>
Gerrit-HasComments: Yes