[PATCH] osmo-bts[master]: si2q: do not consider count update as error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Jul 11 16:22:51 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3180

to look at the new patch set (#2).

si2q: do not consider count update as error

The number of SI2quater messages might be updated dynamically by
BSC (via 'bts 0 resend-system-information' command for example). Log it
but do not return error.

Related: OS#2357
Change-Id: I9625be879c672e20543cc40af288828143ffb983
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/3180/2

diff --git a/src/common/rsl.c b/src/common/rsl.c
index fd8bf13..dc176ea 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -315,9 +315,8 @@
 
 			count = (uint8_t) bitvec_get_uint(&bv, 4);
 			if (bts->si2q_count && bts->si2q_count != count) {
-				LOGP(DRSL, LOGL_ERROR, " Rx RSL SI2quater count changed while receiving: %u -> %d\n",
+				LOGP(DRSL, LOGL_NOTICE, " Rx RSL SI2quater count updated: %u -> %d\n",
 				     bts->si2q_count, count);
-				return rsl_tx_error_report(trx, RSL_ERR_IE_CONTENT);
 			}
 
 			bts->si2q_count = count;

-- 
To view, visit https://gerrit.osmocom.org/3180
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9625be879c672e20543cc40af288828143ffb983
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list