This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: configure.ac: Fix C(PP)FLAGS for BSD build ...................................................................... configure.ac: Fix C(PP)FLAGS for BSD build Issue first found in libosmocore. It seems the BSD build doesn't use bash which means using += to append to a variable doesn't work correctly. Change-Id: Id509351104bc7466114d4b9be450814254110f44 --- M configure.ac 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 535d1c3..9b62f3e 100644 --- a/configure.ac +++ b/configure.ac @@ -26,8 +26,8 @@ AC_CONFIG_MACRO_DIR([m4]) -CFLAGS+=" -Wall" -CPPFLAGS+=" -Wall" +CFLAGS="$CFLAGS -Wall" +CPPFLAGS="$CPPFLAGS -Wall" # The following test is taken from WebKit's webkit.m4 saved_CFLAGS="$CFLAGS" @@ -58,8 +58,8 @@ [sanitize=$enableval], [sanitize="no"]) if test x"$sanitize" = x"yes" then - CFLAGS+=" -fsanitize=address -fsanitize=undefined" - CPPFLAGS+=" -fsanitize=address -fsanitize=undefined" + CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" + CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi _cflags_save=$CFLAGS -- To view, visit https://gerrit.osmocom.org/3137 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id509351104bc7466114d4b9be450814254110f44 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder