[MERGED] osmo-iuh[master]: rua_to_scu(): add debug log for calling/called addr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jul 6 13:53:18 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: rua_to_scu(): add debug log for calling/called addr
......................................................................


rua_to_scu(): add debug log for calling/called addr

This might help in resolving whether we are conforming to SCCP specs regarding
our calling/called address choices.

Change-Id: Ie91953f7e9033419257d556d3a9f14e125f5c60d
---
M src/hnbgw_rua.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw_rua.c b/src/hnbgw_rua.c
index 54c455b..b610437 100644
--- a/src/hnbgw_rua.c
+++ b/src/hnbgw_rua.c
@@ -226,6 +226,11 @@
 		prim->u.connect.calling_addr = cn->gw->sccp.local_addr;
 		prim->u.connect.sccp_class = 2;
 		prim->u.connect.conn_id = map->scu_conn_id;
+		/* Two separate logs because of osmo_sccp_addr_dump(). */
+		DEBUGP(DRUA, "RUA to SCCP N_CONNECT: called_addr:%s\n",
+		       osmo_sccp_addr_dump(&prim->u.connect.called_addr));
+		DEBUGP(DRUA, "RUA to SCCP N_CONNECT: calling_addr:%s\n",
+		       osmo_sccp_addr_dump(&prim->u.connect.calling_addr));
 		break;
 	case OSMO_SCU_PRIM_N_DATA:
 		prim->u.data.conn_id = map->scu_conn_id;
@@ -237,6 +242,11 @@
 	case OSMO_SCU_PRIM_N_UNITDATA:
 		prim->u.unitdata.called_addr = *remote_addr;
 		prim->u.unitdata.calling_addr = cn->gw->sccp.local_addr;
+		/* Two separate logs because of osmo_sccp_addr_dump(). */
+		DEBUGP(DRUA, "RUA to SCCP N_UNITDATA: called_addr:%s\n",
+		       osmo_sccp_addr_dump(&prim->u.unitdata.called_addr));
+		DEBUGP(DRUA, "RUA to SCCP N_UNITDATA: calling_addr:%s\n",
+		       osmo_sccp_addr_dump(&prim->u.unitdata.calling_addr));
 		break;
 	default:
 		return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/3112
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie91953f7e9033419257d556d3a9f14e125f5c60d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list