openbsc[master]: smpp: fix return cause

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jul 5 15:31:51 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/3126/3/openbsc/src/libmsc/smpp_smsc.c
File openbsc/src/libmsc/smpp_smsc.c:

Line 326: 	return (acl) ? 38 /* network out of order */ : 1 /* number unsassigned */;
Can we use define instead of numbers in here? This would also eliminate the need for comments in here.


-- 
To view, visit https://gerrit.osmocom.org/3126
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3241d50a78fa611981e55fef6ae4c72b0a2a167
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list