This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/3113/1/src/hnbgw_cn.c File src/hnbgw_cn.c: Line 243: static bool osmo_sccp_addr_match(const struct osmo_sccp_addr *a, const struct osmo_sccp_addr *b) please don't introduce functions with osmo_ prefix which are not part of the library. I understand it's a static function at this point only, but we shouldn't make it too easy for somebody else to later make it non-static and pollute the namespace with possible future clashes of similarly-named functions in the libraries. -- To view, visit https://gerrit.osmocom.org/3113 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7190b4c3a05e8bac0eeffa1eab18c9e47429cb17 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes