[PATCH] osmo-iuh[master]: set RANAP msgb headroom to 512 (times two)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 3 20:49:22 UTC 2017


Review at  https://gerrit.osmocom.org/3114

set RANAP msgb headroom to 512 (times two)

With a headroom of 256, the SGSN crashes with:

  msgb(0x6e3b90): Not enough headroom msgb_push (256 < 264)

I'm not perfectly sure what amount of headroom is strictly necessary. The only
reason to pick 512 is that it is twice the amount of 256.

Change-Id: I9a193846902a0477af0873f78283c4f2bedaf5dd
---
M src/ranap_common.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/14/3114/1

diff --git a/src/ranap_common.c b/src/ranap_common.c
index a468229..13c913f 100644
--- a/src/ranap_common.c
+++ b/src/ranap_common.c
@@ -291,7 +291,7 @@
 
 static struct msgb *ranap_msgb_alloc(void)
 {
-	return msgb_alloc_headroom(1024+256, 256, "RANAP Tx");
+	return msgb_alloc_headroom(1024+512, 512, "RANAP Tx");
 }
 
 static struct msgb *_ranap_gen_msg(RANAP_RANAP_PDU_t *pdu)

-- 
To view, visit https://gerrit.osmocom.org/3114
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a193846902a0477af0873f78283c4f2bedaf5dd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list