libosmo-sccp[master]: vty: Check returncode of osmo_ss7_pointcode_parse()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 3 12:50:36 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

good, but can be improved:

https://gerrit.osmocom.org/#/c/3102/1/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

Line 170: 		vty_out(vty, "Invalid point code%s", VTY_NEWLINE);
also log the invalid point code: argv[0]. Same below.


-- 
To view, visit https://gerrit.osmocom.org/3102
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6d92b1d135063dfd0a26bc23a89802cb3b1a78
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list