openbsc[master]: add struct bsc_sub, separating libbsc from gsm_subscriber

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jan 31 13:21:57 UTC 2017


Patch Set 4: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libbsc/bsc_vty.c
File openbsc/src/libbsc/bsc_vty.c:

Line 1024: 	vty_out(vty, "    Use count: %d%s", bsub->use_count, VTY_NEWLINE);
->name has some overlap.. shall we have tmsi != GSM_RESERVED_TMSI.. in the name sprintf code as well?


https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libbsc/paging.c
File openbsc/src/libbsc/paging.c:

Line 80
no replacement for this?


https://gerrit.osmocom.org/#/c/1682/4/openbsc/src/libcommon-cs/common_cs.c
File openbsc/src/libcommon-cs/common_cs.c:

Line 73: 	net->bsc_subscribers = talloc_zero(net, struct llist_head);
only done to have a talloc context?


-- 
To view, visit https://gerrit.osmocom.org/1682
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list