[MERGED] openggsn[master]: abi/debian: Bump ABI version of libgtp after struct size change

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Jan 30 09:53:32 UTC 2017


Holger Freyther has submitted this change and it was merged.

Change subject: abi/debian: Bump ABI version of libgtp after struct size change
......................................................................


abi/debian: Bump ABI version of libgtp after struct size change

The gsn_t changed the size with the addition of the ctrl pointer.
Bump the SO version to not break osmo-sgsn/ggsn on upgrade.

Call the -dev package libgtp-dev to follow the rest of Osmocom and
to ease making releases here.

Change-Id: Iac4d6d2effde1a6b2f60b1e1b49c91513d5ca8c3
---
M debian/changelog
M debian/control
R debian/libgtp-dev.install
R debian/libgtp1.install
M gtp/Makefile.am
5 files changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/debian/changelog b/debian/changelog
index a00671b..5d52bfd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,9 @@
 openggsn (0.93) UNRELEASED; urgency=medium
 
   * Bump version to ease upgrading from Debian SID.
+  * Bump libgtp SO version after ABI change.
 
- -- Holger Hans Peter Freyther <holger at moiji-mobile.com>  Tue, 24 May 2016 22:53:16 +0200
+ -- Holger Hans Peter Freyther <holger at moiji-mobile.com>  Tue, 24 Jan 2017 17:26:26 +0100
 
 openggsn (0.92) precise; urgency=medium
 
diff --git a/debian/control b/debian/control
index 9306656..4e5b168 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@
  operators as the interface between the Internet and the rest of the
  mobile network infrastructure.
 
-Package: libgtp0
+Package: libgtp1
 Architecture: any
 Multi-Arch: same
 Section: libs
@@ -36,12 +36,12 @@
  This library is part of openggsn and implements the GTP protocol between
  SGSN (Serving GPRS support node) and GGSN.
 
-Package: libgtp0-dev
+Package: libgtp-dev
 Architecture: any
 Multi-Arch: same
 Section: libdevel
 Depends: ${misc:Depends},
-         libgtp0 (= ${binary:Version})
+         libgtp1 (= ${binary:Version})
 Description: Development files for libgtp
  OpenGGSN is a Gateway GPRS Support Node (GGSN). It is used by mobile
  operators as the interface between the Internet and the rest of the
@@ -54,6 +54,6 @@
 Section: debug
 Architecture: any
 Priority: extra
-Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp0 (= ${binary:Version}), openggsn (= ${binary:Version})
+Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp1 (= ${binary:Version}), openggsn (= ${binary:Version})
 Multi-Arch: same
 Description: Debug symbols for OpenGGSN
diff --git a/debian/libgtp0-dev.install b/debian/libgtp-dev.install
similarity index 100%
rename from debian/libgtp0-dev.install
rename to debian/libgtp-dev.install
diff --git a/debian/libgtp0.install b/debian/libgtp1.install
similarity index 100%
rename from debian/libgtp0.install
rename to debian/libgtp1.install
diff --git a/gtp/Makefile.am b/gtp/Makefile.am
index 9586dfe..32025d6 100644
--- a/gtp/Makefile.am
+++ b/gtp/Makefile.am
@@ -1,3 +1,7 @@
+# This is _NOT_ the library release version, it's an API version.
+# Please read chapter "Library interface versions" of the libtool documentation
+# before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
+LIBVERSION=1:0:0
 lib_LTLIBRARIES = libgtp.la
 
 include_HEADERS = gtp.h pdp.h gtpie.h
@@ -5,6 +9,7 @@
 AM_CFLAGS = -O2 -fno-builtin -Wall -DSBINDIR='"$(sbindir)"' -ggdb $(LIBOSMOCORE_CFLAGS)
 
 libgtp_la_SOURCES = gtp.c gtp.h gtpie.c gtpie.h pdp.c pdp.h lookupa.c lookupa.h queue.c queue.h
+libgtp_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined
 libgtp_la_LIBADD = $(LIBOSMOCORE_LIBS)
 
 

-- 
To view, visit https://gerrit.osmocom.org/1657
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac4d6d2effde1a6b2f60b1e1b49c91513d5ca8c3
Gerrit-PatchSet: 2
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>


More information about the gerrit-log mailing list