[PATCH] libosmo-sccp[master]: cosmetic: sua.c: comments

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 27 09:00:05 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1675

to look at the new patch set (#2).

cosmetic: sua.c: comments

Add some human readable names.

Change-Id: If4aa15aae8b03c764a45b866a751eb3fbabebec1
---
M src/sua.c
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/75/1675/2

diff --git a/src/sua.c b/src/sua.c
index b8e0c09..c363cdb 100644
--- a/src/sua.c
+++ b/src/sua.c
@@ -870,7 +870,7 @@
 	return rc;
 }
 
-/* RFC 3868 3.3.3 / SCCP CR */
+/* RFC 3868 3.3.3 / SCCP CR (Connection Request) */
 static int sua_rx_core(struct osmo_sccp_link *link, struct xua_msg *xua)
 {
 	struct osmo_scu_prim *prim;
@@ -915,7 +915,7 @@
 	return 0;
 }
 
-/* RFC 3868 3.3.4 / SCCP CC */
+/* RFC 3868 3.3.4 / SCCP CC (Connection Confirm) */
 static int sua_rx_coak(struct osmo_sccp_link *link, struct xua_msg *xua)
 {
 	struct osmo_scu_prim *prim;
@@ -976,7 +976,7 @@
 	return 0;
 }
 
-/* RFC 3868 3.3.5 / SCCP CREF */
+/* RFC 3868 3.3.5 / SCCP CREF (Connection Refused) */
 static int sua_rx_coref(struct osmo_sccp_link *link, struct xua_msg *xua)
 {
 	struct osmo_scu_prim *prim;
@@ -1030,7 +1030,7 @@
 	return 0;
 }
 
-/* RFC 3868 3.3.6 / SCCP RLSD */
+/* RFC 3868 3.3.6 / SCCP RLSD (Released) */
 static int sua_rx_relre(struct osmo_sccp_link *link, struct xua_msg *xua)
 {
 	struct osmo_scu_prim *prim;
@@ -1082,7 +1082,7 @@
 	return 0;
 }
 
-/* RFC 3868 3.3.7 / SCCP RLC */
+/* RFC 3868 3.3.7 / SCCP RLC (Release Complete)*/
 static int sua_rx_relco(struct osmo_sccp_link *link, struct xua_msg *xua)
 {
 	struct osmo_scu_prim *prim;
@@ -1127,7 +1127,7 @@
 
 }
 
-/* RFC3868 3.3.1 / SCCP DT1 */
+/* RFC3868 3.3.1 / SCCP DT1 (Data Form 1) */
 static int sua_rx_codt(struct osmo_sccp_link *link, struct xua_msg *xua)
 {
 	struct osmo_scu_prim *prim;

-- 
To view, visit https://gerrit.osmocom.org/1675
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4aa15aae8b03c764a45b866a751eb3fbabebec1
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list