openbsc[master]: SGSN: Integrate basic support for UMTS AKA

Max gerrit-no-reply at lists.osmocom.org
Thu Jan 26 09:54:00 UTC 2017


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/1683/3/openbsc/src/gprs/gprs_gmm.c
File openbsc/src/gprs/gprs_gmm.c:

Line 556: 	} else
purely cosmetic but you can drop else in here because you print ")\n" either way.


Line 702: 		if (l > sizeof(res)-4)
Another cosmetic: spaces around +-


Line 714: 		LOGMMCTXP(LOGL_NOTICE, ctx, "Mismatch: expected SRES = %s\n",
In spec the part we have called SRES, the part MS returned called RES - it's better to adhere to this terminology to avoid confusion.


-- 
To view, visit https://gerrit.osmocom.org/1683
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a0cefba5e4e7f02cc2eaf6ec006ac07d5c1816
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list