osmo-bts[master]: Add ctrl command to send OML alert

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jan 25 11:48:52 UTC 2017


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1575/5/src/common/bts_ctrl_commands.c
File src/common/bts_ctrl_commands.c:

Line 82: 	osmo_signal_dispatch(SS_FAIL, OSMO_EVT_EXT_ALARM, rep);
see my other comment.  This is not how signals work. You cannot pass allocated data into them and then have one (random) registered signal subscriber free it.  We would have to have an explicit destructor for a signal if you wanted to do that.


-- 
To view, visit https://gerrit.osmocom.org/1575
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I228cb71ab945e19e3747843469a52f577ee32f97
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list