osmo-pcu[master]: PDCH allocation across two TRX

Max gerrit-no-reply at lists.osmocom.org
Tue Jan 24 17:18:07 UTC 2017


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/1512/3/src/bts.cpp
File src/bts.cpp:

Line 414:  *  \param[in] _trx The uint8_t *
Please be more verbose: not only type, but what it is and what it's for.


Line 434: 		*_trx = use_trx;
_trx is marked as [in] but here you assign smth to it - shall it be marked as [out]? What's the purpose of _trx?


-- 
To view, visit https://gerrit.osmocom.org/1512
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I222c3340872ffa1dd6e8fabe5276d793e660f67d
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list