osmo-bts[master]: OML: internalize failure reporting

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jan 24 13:10:07 UTC 2017


Patch Set 4:

> Hmm, sure, why not. How should API look like?

Like any API: Expressive, flexible, easy to understand, easy to get right, hard to use wrong, with no need for boilerplate code.  The rest is up to you.  Forcing people to use talloc_sprintf() befoer calling it doesn't really sound all that great.

Firstly, I don't understand why we didn't have to do dynamic allocations before this proposed change and we now use them.  Secondl, if we use them, the allocation and release of the memory should as far as possible be hidden from the caller.  The caller just wants to state "I have alarm XY" in an easy way, without caring about the implementation behind.

-- 
To view, visit https://gerrit.osmocom.org/1570
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I738555c547926e97b325ab53763c0076c42309bc
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list