openbsc[master]: CTRL: remove boilerplate

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jan 24 13:06:36 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/1576/3/openbsc/tests/ctrl_test_runner.py
File openbsc/tests/ctrl_test_runner.py:

Line 222:         self.assertEquals(r['error'], 'Write Only attribute')
Ok, libosmocore indicates "Write Only" with uppercase-O, so it must match here.  Buy why do we expect "Read only" with lower csae in other cases here, despite CTRL_CMD_DEFINE_RO using "Read Only" with uppercase?


-- 
To view, visit https://gerrit.osmocom.org/1576
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bcea0b4f4b8f535bef2b423f2013b8b4a218b5b
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list