libosmocore[master]: Add osmo_sock_init_ifd()
gerrit-no-reply at lists.osmocom.org
Mon Jan 23 12:05:50 UTC 2017
Patch Set 2: Code-Review-2
the 'o' in init_ofd() refers to the fact that it applies to an osmo_fd, and not an 'int fd'. I believe we once had code that applied to a raw fd, not ofd.
The rationale behind registering for BSC_FD_READ is that we assume the code always cares about receiving data from a socket. BSC_FD_WRITE should only be set *exactly* before writing something, i.e. when you have a pending buffer to be written to the socket. so the BSC_FD_WRITE is set when you want to write, e.g. from the write_queue code or whatever is writing.
To view, visit https://gerrit.osmocom.org/1624
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
More information about the gerrit-log