libosmocore[master]: Expand and expose ctrl connection allocation

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Jan 23 00:49:24 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/1629/2/src/ctrl/control_if.c
File src/ctrl/control_if.c:

Line 383: 	ccon->write_queue.bfd.data = data ? data : ccon;
I think this is a bad decision. Let's plat the game of least surprise. I wake you up at 4:30 am.. give you a ctrl_connection pointer and I ask what bfd.data points to. What do you answer and why?


-- 
To view, visit https://gerrit.osmocom.org/1629
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ed809cbebfd3d7dd08b4ed9137b39ff192e32
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list