[PATCH] openbsc[master]: Revert "Revert "Turn some warnings into errors""

Max gerrit-no-reply at lists.osmocom.org
Fri Jan 20 12:10:48 UTC 2017


Review at  https://gerrit.osmocom.org/1637

Revert "Revert "Turn some warnings into errors""

The commit 98bc7fa50d0731864297f8fb82932d480c426ff6 reverted
fd161ccce8ecaad3ddd32dd8b696902e81593ae3 by mistake. Fix this and add
explicit check for m4 macro availability to prevent this mistake from
reappearing.

Change-Id: I631bde22e79ec0318eb9c8114db5861a1d635816
---
M debian/control
M openbsc/configure.ac
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/37/1637/1

diff --git a/debian/control b/debian/control
index 44262b9..93b4bd3 100644
--- a/debian/control
+++ b/debian/control
@@ -4,6 +4,7 @@
 Priority: optional
 Build-Depends: debhelper (>= 9),
                autotools-dev,
+               autoconf-archive,
                pkg-config,
                libgtp0-dev,
                libosmocore-dev,
diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index 0753834..ec2ef49 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -140,6 +140,18 @@
 CFLAGS="$saved_CFLAGS"
 AC_SUBST(SYMBOL_VISIBILITY)
 
+m4_ifdef([AX_CHECK_COMPILE_FLAG], [
+             AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
+             AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"])
+             AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"])
+             AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"])
+             AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"])
+             AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"])
+         ], [
+             AC_MSG_ERROR([You have to install autoconf-archive package.])
+         ]
+)
+
 # Coverage build taken from WebKit's configure.in
 AC_MSG_CHECKING([whether to enable code coverage support])
 AC_ARG_ENABLE(coverage,

-- 
To view, visit https://gerrit.osmocom.org/1637
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I631bde22e79ec0318eb9c8114db5861a1d635816
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>


More information about the gerrit-log mailing list