libosmocore[master]: stats: Build UDP socket code only if sys/socket.h exists

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jan 17 15:37:45 UTC 2017


Patch Set 1: Code-Review-1

(1 comment)

Not sure how to guard this differently, move it to the .c file?

https://gerrit.osmocom.org/#/c/1607/1/include/osmocom/core/stats.h
File include/osmocom/core/stats.h:

Line 66: #ifdef HAVE_SYS_SOCKET_H
I think it is dangerous to have different struct sizes depending on config.h being included at the right time. E.g. apps using this struct need to check for udp sockets too...


-- 
To view, visit https://gerrit.osmocom.org/1607
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6beb4fcc394ed7d3f8dd7a097b6e998245ecf401
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list