osmo-bts[master]: octphy: Improve OML ADM state handling

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jan 17 13:27:00 UTC 2017


Patch Set 12: Code-Review-1

(2 comments)

'trx_locked' and 'granted' need explaining, possibly in the commit log

https://gerrit.osmocom.org/#/c/906/12/src/osmo-bts-octphy/l1_oml.c
File src/osmo-bts-octphy/l1_oml.c:

Line 1568: 			trx_locked = 1;
wait, what? trx_locked is a global variable for all TRX? Shouldn't this be part of struct gsm_bts_trx instead?


Line 1609: 	if (granted) {
interesting how 'granted' will never end up being 0 here


-- 
To view, visit https://gerrit.osmocom.org/906
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I034114beca95210169429d8ac1eb8648df12fc6c
Gerrit-PatchSet: 12
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list