osmo-pcu[master]: Sanitizer fix for invalid value of egprs_puncturing_values

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jan 16 12:36:06 UTC 2017


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/1411/4/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 771: 		rlc.cps = gprs_rlc_mcs_cps(cs, punct[0], punct[1], need_padding);
> The CPS field is valid only for EGPRS case. hence calling this function is 
This fix should be in a separate commit: it is unrelated to the sanitizer issue discussed in this patch, right?


-- 
To view, visit https://gerrit.osmocom.org/1411
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice54edc7e4a936eb2f2dd8a243673a30dceef542
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list