[PATCH] osmo-pcu[master]: Log additional info for radio errors

Max gerrit-no-reply at lists.osmocom.org
Mon Jan 16 09:10:29 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1578

to look at the new patch set (#4).

Log additional info for radio errors

Change-Id: I936a07ce87f05d9c3dc351dc3bdc4f00d78265e0
Related: OS#1553
---
M src/bts.cpp
M src/sba.cpp
2 files changed, 14 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/1578/4

diff --git a/src/bts.cpp b/src/bts.cpp
index a47d7d8..b4e18e3 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -909,9 +909,9 @@
 void gprs_rlcmac_pdch::rcv_control_ack(Packet_Control_Acknowledgement_t *packet, uint32_t fn)
 {
 	struct gprs_rlcmac_tbf *tbf, *new_tbf;
-	uint32_t tlli = 0;
+	uint32_t tlli = packet->TLLI;
+	GprsMs *ms = bts()->ms_by_tlli(tlli);
 
-	tlli = packet->TLLI;
 	tbf = bts()->ul_tbf_by_poll_fn(fn, trx_no(), ts_no);
 	if (!tbf)
 		tbf = bts()->dl_tbf_by_poll_fn(fn, trx_no(), ts_no);
@@ -920,6 +920,15 @@
 		LOGP(DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with "
 			"unknown FN=%u TLLI=0x%08x (TRX %d TS %d)\n",
 			fn, tlli, trx_no(), ts_no);
+		if (ms)
+			LOGP(DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with "
+			     "unknown TBF corresponds to MS with IMSI %s, TA %d, "
+			     "uTBF (TFI=%d, state=%s), uTBF (TFI=%d, state=%s)\n",
+			     ms->imsi(), ms->ta(),
+			     ms->ul_tbf() ? ms->ul_tbf()->tfi() : 0,
+			     ms->ul_tbf() ? ms->ul_tbf()->state_name() : "None",
+			     ms->dl_tbf() ? ms->dl_tbf()->tfi() : 0,
+			     ms->dl_tbf() ? ms->dl_tbf()->state_name() : "None");
 		return;
 	}
 	tbf->update_ms(tlli, GPRS_RLCMAC_UL_TBF);
diff --git a/src/sba.cpp b/src/sba.cpp
index 46c1431..5d75b17 100644
--- a/src/sba.cpp
+++ b/src/sba.cpp
@@ -127,7 +127,9 @@
 
 int SBAController::timeout(struct gprs_rlcmac_sba *sba)
 {
-	LOGP(DRLCMAC, LOGL_NOTICE, "Poll timeout for SBA\n");
+	LOGP(DRLCMAC, LOGL_NOTICE,
+	     "Poll timeout for SBA (TRX=%u, TS=%u, FN=%u, TA=%u)\n", sba->trx_no,
+	     sba->ts_no, sba->fn, sba->ta);
 	m_bts.sba_timedout();
 	free_sba(sba);
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/1578
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I936a07ce87f05d9c3dc351dc3bdc4f00d78265e0
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list