[MERGED] openbsc[master]: Revert "Turn some warnings into errors"

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Jan 13 02:52:08 UTC 2017

Neels Hofmeyr has submitted this change and it was merged.

Change subject: Revert "Turn some warnings into errors"

Revert "Turn some warnings into errors"

This introduces a failure with ./configure on my machine:

  ../configure: line 6612: syntax error near unexpected token `-Werror=implicit,'
  ../configure: line 6612: `AX_CHECK_COMPILE_FLAG(-Werror=implicit, CFLAGS="$CFLAGS -Werror=implicit")'
  Makefile:420: recipe for target 'config.status' failed
  make[1]: *** [config.status] Error 2

Installing autoconf-archive did not fix the error.
So even though jenkins seems to accept this, I cannot build with this patch.

Let's find out how to do this in a way that all systems can still build
and then re-apply this patch.

This reverts commit fd161ccce8ecaad3ddd32dd8b696902e81593ae3.

Change-Id: I2b368500b07f233882ef854eca1fa21f6df39e29
M debian/control
M openbsc/configure.ac
2 files changed, 0 insertions(+), 9 deletions(-)

  Neels Hofmeyr: Looks good to me, approved; Verified

diff --git a/debian/control b/debian/control
index d9432e2..79f18df 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,6 @@
 Priority: optional
 Build-Depends: debhelper (>= 9),
-               autoconf-archive,
diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index 9fd7325..0753834 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -140,14 +140,6 @@
-# FIXME: use CC_CHECK_CFLAG_APPEND([-Werror=implicit])
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"])
 # Coverage build taken from WebKit's configure.in
 AC_MSG_CHECKING([whether to enable code coverage support])

To view, visit https://gerrit.osmocom.org/1591
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b368500b07f233882ef854eca1fa21f6df39e29
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>

More information about the gerrit-log mailing list