[PATCH] libosmocore[master]: stats_test: fix mismatching osmo_stats_reporter->send_item s...

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 12 23:12:51 UTC 2017


Review at  https://gerrit.osmocom.org/1587

stats_test: fix mismatching osmo_stats_reporter->send_item signature

The function pointer expects the last arg as int64_t, stats_test.c uses
an int instead. Fix the argument type as well as the printf format for it.

Fixes this compiler warning seen on our FreeBSD build slave:

    CC       stats/stats_test.o
  ../../tests/stats/stats_test.c:288:18: warning: incompatible pointer types assigning to 'int (*)(struct osmo_stats_reporter *, const struct osmo_stat_item_group *, const struct osmo_stat_item_desc *, int64_t)' from 'int (struct osmo_stats_reporter *, const struct osmo_stat_item_group *, const struct osmo_stat_item_desc *, int)' [-Wincompatible-pointer-types]
          srep->send_item = stats_reporter_test_send_item;
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 warning generated.

Change-Id: I91cbfd4dd25a881b803943430101dabf07dafc7c
---
M tests/stats/stats_test.c
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/1587/1

diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c
index 75ddf18..0234460 100644
--- a/tests/stats/stats_test.c
+++ b/tests/stats/stats_test.c
@@ -27,6 +27,7 @@
 #include <osmocom/core/stats.h>
 
 #include <stdio.h>
+#include <inttypes.h>
 
 enum test_ctr {
 	TEST_A_CTR,
@@ -251,9 +252,9 @@
 
 static int stats_reporter_test_send_item(struct osmo_stats_reporter *srep,
 	const struct osmo_stat_item_group *statg,
-	const struct osmo_stat_item_desc *desc, int value)
+	const struct osmo_stat_item_desc *desc, int64_t value)
 {
-	printf("  %s: item p=%s g=%s i=%u n=%s v=%d u=%s\n",
+	printf("  %s: item p=%s g=%s i=%u n=%s v=%"PRId64" u=%s\n",
 		srep->name,
 		srep->name_prefix ? srep->name_prefix : "",
 		statg->desc->group_name_prefix, statg->idx,

-- 
To view, visit https://gerrit.osmocom.org/1587
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91cbfd4dd25a881b803943430101dabf07dafc7c
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list