openbsc[master]: vty: remove ignored logging parameters

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 12 22:11:16 UTC 2017


Patch Set 1:

IMHO commit log lacks critical info why this is unused: log_vty_command_*() no longer use their argument. Thus logging_vty_add_cmds() doesn't either.

Maybe also add API doc to mention unused parameter to logging_vty_add_cmds()? Maybe remove the parameter altogether?

-- 
To view, visit https://gerrit.osmocom.org/1583
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62f752fd88f1d8fefa563648f9864c7c31f87991
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list