libosmocore[master]: logging: remove code duplication
gerrit-no-reply at lists.osmocom.org
Thu Jan 12 21:59:03 UTC 2017
Patch Set 1: Code-Review-1
nice, it seems DEBUGP so far didn't take advantage of early exiting to prevent performance loss when debug level is not enabled? Excellent catch!
two minor details...
Line 39: LOGPSRC(ss, level, NULL, 0, fmt, ## args)
why move this around? IMHO its place above LOGPC makes more sense than below.
We should probably keep this implementation around for backwards compat with binary code built with old DEBUGP macros ... until when, the next major release? forever?
To view, visit https://gerrit.osmocom.org/1580
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
More information about the gerrit-log