libosmocore[master]: logging: remove code duplication

Neels Hofmeyr gerrit-no-reply at
Thu Jan 12 21:59:03 UTC 2017

Patch Set 1: Code-Review-1


nice, it seems DEBUGP so far didn't take advantage of early exiting to prevent performance loss when debug level is not enabled? Excellent catch!

two minor details...
File include/osmocom/core/logging.h:

Line 39: 	LOGPSRC(ss, level, NULL, 0, fmt, ## args)
why move this around? IMHO its place above LOGPC makes more sense than below.
File src/logging.c:

Line 434
We should probably keep this implementation around for backwards compat with binary code built with old DEBUGP macros ... until when, the next major release? forever?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c92bd4824c44fc22cc733ce7a88da86e58ed93
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at>
Gerrit-HasComments: Yes

More information about the gerrit-log mailing list