libosmocore[master]: abis_nm_fail_evt_rep(): use va_list explicitly

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 11 14:51:41 UTC 2017


Patch Set 1: Code-Review-1

(1 comment)

marking to have the question resolved first

https://gerrit.osmocom.org/#/c/1569/1//COMMIT_MSG
Commit Message:

Line 11: vararg functions similar to vprintff() vs printf().
but it disallows calling "directly". Usually one has both variants, one with '...' that simply passes on to the va_list version, and another one suffixed _va with a va_list arg for lower level access. Will there be no callers that would like to provide variable number of arguments instead of a va_list? What code does this affect? Will e.g. the openbsc build break with this patch?


-- 
To view, visit https://gerrit.osmocom.org/1569
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib293dec1c2de9b664584a8456c782ea7b6dd8555
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list